Lint 1.61.0 #640
Merged
Lint 1.61.0 #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
…, and unused Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
rickard-von-essen
force-pushed
the
lint-1.61.0
branch
from
f92b8c3
to
7f23bdc
Compare
rickard-von-essen
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
jeanduplessis
requested changes
Oct 29, 2024
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
rickard-von-essen
force-pushed
the
lint-1.61.0
branch
from
7f23bdc
to
dbc74fc
Compare
jeanduplessis
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Update crossplane/build to
d3155548bfab68fc8bea64c5526642b7b565ae33which includes an update of golangci-lint to 1.61.0 to fix problems linting on macOS (arm64). See crossplane/build#23Also includes the following deprecation fixes:
.golangci.ymlconfig for several deprecated config settingsinterfacermegacheckwithgosimple,staticcheck, andunusedENVinDockerfileI have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Lint now works on macOS.